Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add claim doesn't support monolingual text #33

Closed
jhsoby opened this issue Oct 30, 2017 · 8 comments
Closed

add claim doesn't support monolingual text #33

jhsoby opened this issue Oct 30, 2017 · 8 comments

Comments

@jhsoby
Copy link

jhsoby commented Oct 30, 2017

Similar to issue #30 in that it's about an unsupported datatype.

The datatype monolingual string requires a two parts: A language code and a string. It's currently not possible to add that via this tool (or, alternatively, I don't know the correct syntax to do so). In QuickStatements, the syntax to do this is languagecode:"string", perhaps the same syntax should be used here? Tested with P1705.

@jhsoby
Copy link
Author

jhsoby commented Oct 30, 2017

Oh, and similarly, we need some syntax for how to add this for create-item.

@maxlath maxlath closed this as completed in 4448a02 Nov 3, 2017
maxlath added a commit that referenced this issue Nov 3, 2017
allowing to pass an object as value to provide for the needs of monolingual text or quantities with a unit
fix #33
@maxlath
Copy link
Owner

maxlath commented Nov 3, 2017

The monolingual text claim issue got fixed by 18aa868, see the rich claim value documentation

And for create-item (and now also edit-item), the updated documentation is here

@jhsoby
Copy link
Author

jhsoby commented Nov 5, 2017

Thank you very much! 👍

@maxlath
Copy link
Owner

maxlath commented Nov 5, 2017

you're welcome :)

@jhsoby
Copy link
Author

jhsoby commented Dec 24, 2017

Sorry to bother you about this again, but I'm not getting this to work with create-item. I'm wondering if I'm doing something wrong, or if it is a bug. The command I'm trying is this:

wd create-item '{"labels":{"nb":"Lundeborg"},"descriptions":{"nb":"etternavn"},"claims":{"P1705":{"text":"Lundeborg","language":"mul"}}}'

The error I'm getting is missing claim value [ 'P1705', undefined ]

With add-claim it works as it should.

@maxlath
Copy link
Owner

maxlath commented Dec 27, 2017

And its was indeed a bug in wikidata-edit, that was fixed in maxlath/wikibase-edit@570b2d1

The patch was published in wikidata-cli v5.7.2. Thank you for spotting and sorry for the trouble!

@jhsoby
Copy link
Author

jhsoby commented Dec 27, 2017

@maxlath It's working, hurrah! Thank you very much, and happy new year to you! :-)

@maxlath
Copy link
Owner

maxlath commented Dec 27, 2017

you're welcome! :D
happy new year to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants