Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How-to get a claim guid #33

Closed
mwtoews opened this issue Jul 14, 2019 · 1 comment
Closed

How-to get a claim guid #33

mwtoews opened this issue Jul 14, 2019 · 1 comment

Comments

@mwtoews
Copy link

mwtoews commented Jul 14, 2019

The How-to guide describes wdEdit.claim.add, which works wonderfully. However, to add qualifiers and references for this claim, a GUID is required. The How-to shows a const claimGuid declaration, but does not demonstrate how to get the claimGuid for a claim. An example to get this dynamically would be appreciated.

Also, the how-to uses const claimGuid, but uses a different name, guid, in some of the functions. This is possibly an error, as these functions should use claimGuid.

maxlath added a commit that referenced this issue Jul 20, 2020
to avoid confusion expressed in #33
maxlath added a commit that referenced this issue Jul 20, 2020
maxlath added a commit that referenced this issue Jul 20, 2020
@maxlath
Copy link
Owner

maxlath commented Jul 20, 2020

hi, sorry for the delayed answer, this somehow got out of my radar ^^

but I have some good news!

  • there is now a section in the documentation on how to get a claim guid (7bf317c)
  • the variable name claimGuid was removed from the documentation to avoid confusion (e267e08)
  • but in your use-case, since v4.6.0, maybe you don't need to get the claim guid anymore: qualifiers and references can directly be added from wbEdit.claim.add \o/ (or rather from wbEdit.claim.create as we now prefer to call it)

@maxlath maxlath closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants