config: take a wgScriptPath parameter #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressing #69
lucaswerkmeister
approved these changes
Jun 1, 2021
lucaswerkmeister
added a commit
to wmde/WikibaseReconcileEdit
that referenced
this pull request
Jun 1, 2021
|
published in |
lucaswerkmeister
added a commit
to wmde/WikibaseReconcileEdit
that referenced
this pull request
Jun 2, 2021
Since maxlath/wikibase-sdk#78 and maxlath/wikibase-edit#70, those libraries support specifying a script path, so we can now take that out of the base URL instead of throwing it away. npm also updated the package-lock.json to lockfileVersion 2; since this version is compatible with older npm releases, I think that’s okay to keep.
toban
pushed a commit
to wmde/WikibaseReconcileEdit
that referenced
this pull request
Jun 2, 2021
Since maxlath/wikibase-sdk#78 and maxlath/wikibase-edit#70, those libraries support specifying a script path, so we can now take that out of the base URL instead of throwing it away. npm also updated the package-lock.json to lockfileVersion 2; since this version is compatible with older npm releases, I think that’s okay to keep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #69
same as maxlath/wikibase-sdk#78 but for wikibase-edit
@lucaswerkmeister do you want to give a try to that one too?