Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce claims reconciliation capabilities #71

Merged
merged 31 commits into from
Jan 10, 2022
Merged

introduce claims reconciliation capabilities #71

merged 31 commits into from
Jan 10, 2022

Conversation

maxlath
Copy link
Owner

@maxlath maxlath commented Jun 1, 2021 •
edited
Loading

Adds a reconciliation object to edits, allowing to customize the behaviour the lib should adopt to:

  • identify an existing claim as a matching claim
  • determine what changes should be made to that matching claim

See the draft reconciliation section of the How-To for an introduction on the proposed syntax, and the new tests for more details

@maxlath maxlath force-pushed the claims-reconciliation branch 3 times, most recently from b366b17 to 2191d0d Compare June 1, 2021 15:47
@maxlath maxlath mentioned this pull request Jun 1, 2021
Open
@maxlath
turn entity.edit and entity.create primitives into async functions
a05c990 
to prepare for the possibility to do reconciliation, which requires
making requests to the Wikibase API
@maxlath
claim.create/entity.edit: implement basic reconciliation capability
a67cfbc
@maxlath
implement reference reconciliation
4093a88
@maxlath
reconcile_claim: reuse find_snak module value comparators by datatypes
95e4811
@maxlath
refactor comparators
8a4f5c3
@maxlath
reconciliation: test quantity support
faeca09
@maxlath
reconciliation: quantity: unspecified unit do not prevent matching
e180259
@maxlath
reconciliation: quantity: include lowerBound and upperBound to matching
fdc72b8
@maxlath
reconciliation: add basic support for globe-coordinate
fb8bc58
@maxlath
reconciliation: add tests for monolingual text
1db9656
@maxlath
reconciliation: add basic support for time
d61e475
@maxlath
is_matching_snak: add missing datatypes
7207777
@maxlath
validate reconciliation object
e055221 
to prevent not reconciling due to a typo in the reconciliation object name
@maxlath
reconcile_claim: allow to specify matchingReferences properties to me…
fe0bdce 
…rge matching records
@maxlath
reconcile_claim: warn on skipped claim
44e0729
@maxlath
reconcile_claim: allow per-claim reconciliation settings
fc93ed3
@maxlath
validate claim parameters
2a83baa
@maxlath
allow to remove a claim
84b6c6d
@maxlath
remove with reconciliation: remove all matching claims
cf0127d
@maxlath
remove with reconciliation: prevent trying to edit several times the …
fd2a8b8 
…same claim within the same edit

as the result would be a Wikibase error stating that the claim can't be found,
which is less easy to debug than an explicit error message
@maxlath
remove claim: allow to find claims with reconciliation
d57239f
@maxlath
reconciliation: fix case where no claim exists for the target property
58f600e
@maxlath
tests: reconciliation: reorganize
765532d
@maxlath
is_matching_claim: allow to reconcilate on any qualifier
c1b6e97
@maxlath
rename references records -> references
f5d94c7 
a record is just a reference, no need of a new name
@maxlath maxlath merged commit 671dd4b into main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maxlath