-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to keep qualifiers in simplifyClaims() #12
Comments
{
"claims": {
"P279": [ "Q340169", "Q2342494", "Q386724" ]
}
} This would require having a richer output format like {
"claims": {
"P279": [
{ "value": "Q340169", "qualifiers": {} },
{ "value": "Q2342494", "qualifiers": {} },
{ "value": "Q386724", "qualifiers": {} }
]
}
} That could make sense. PR welcome! |
Or:
which is programmatically closer to the original... instead of getting the values of the list, you can now get the keys of the map, and no need to look up the .value... |
Well, I'm not fluent in CoffeeScript, but I'll have a go. I prefer the |
Compiling with coffee 1.12.2 instead of 1.11.1
After
simplifyClaims()
, all qualifiers are discarded. This makes it impossible for e.g. merging P50 (author) and P2093 (author string) after fetching labels, as the P1545 (series ordinal) qualifier is gone. It would be nice to to have an option forsimplifyClaims()
or a similar method to keep these.The text was updated successfully, but these errors were encountered: