Add sticky options #33
Conversation
| @@ -615,7 +618,7 @@ defmodule LiveSelect.Component do | |||
| xmlns="http://www.w3.org/2000/svg" | |||
| viewBox="0 0 20 20" | |||
| fill="currentColor" | |||
| class="w-5 h-5 @class" | |||
| class={["w-5 h-5", @class]} | |||
There was a problem hiding this comment.
This fixes a small bug which prevented the @class interpolation.
lib/live_select/component.ex
Outdated
|
|
||
| option when is_binary(option) or is_atom(option) or is_number(option) -> | ||
| {:ok, %{label: option, value: option}} | ||
| {:ok, %{label: option, value: option, sticky: false}} | ||
|
|
There was a problem hiding this comment.
Let's not change anything in normalize/1: there's no need to set a default value for the sticky flag, just like there is no need to set a default value for the tag_label key. If it's not there, then the option isn't sticky :)
There was a problem hiding this comment.
I left the tuple with 3 options to allow it to be sticky with tuples as well, if you think it's not needed we can remove.
There was a problem hiding this comment.
Yeah let's remove that as well and keep it simple and consistent with the tag_label option: if you want to use sticky or tag_label, then you have to pass a list of maps
| @@ -19,7 +19,7 @@ | |||
| <% else %> | |||
| <%= render_slot(@tag, option) %> | |||
| <% end %> | |||
| <button type="button" data-idx={idx}> | |||
| <button :if={!option[:sticky]} type="button" data-idx={idx}> | |||
There was a problem hiding this comment.
this is all we need to make it work!
|
|
||
| assert_option_removeable(live, 2) | ||
| end | ||
|
|
|
Thanks for taking the time to review. I've implemented your suggestions. |
|
looks great! Thanks again. I will release a new version tomorrow |
Hi again!
This adds the ability to make options unremovable after they're selected.
In our app we share a form with 2 LiveViews and use LiveSelect to handle a nested association, in one of the pages we pre-set a default option that can't be removed but the user is still allowed to add/remove other options.
I've tried to follow your library standards and any feedback to improve my contribution is welcome.
Thanks!