Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pion/webrtc@v3 #26

Closed
Sean-Der opened this issue Jan 1, 2021 · 0 comments · Fixed by #27
Closed

Upgrade to pion/webrtc@v3 #26

Sean-Der opened this issue Jan 1, 2021 · 0 comments · Fixed by #27

Comments

@Sean-Der
Copy link
Collaborator

Sean-Der commented Jan 1, 2021

I am going to submit a PR to upgrade webtty to pion/webrtc v3

I had to make two changes to the code to accommodate API breakage

  • Trickle ICE is enabled by default, used webrtc.GatheringCompletePromise to simulate old behavior
  • A application media section isn't created by default anymore. We create a unused DataChannel when offering
Sean-Der added a commit that referenced this issue Jan 1, 2021
@Sean-Der
Upgrade to pion/webrtc@v3
760fc8b 
Resolves #26
@Sean-Der Sean-Der mentioned this issue Jan 1, 2021
Merged
Sean-Der added a commit that referenced this issue Jan 1, 2021
@Sean-Der
Upgrade to pion/webrtc@v3
40210b7 
Resolves #26
@Sean-Der Sean-Der mentioned this issue Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to pion/webrtc@v3 maxmcd/webtty
2 participants
@Sean-Der and others