New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow javascript modules to also have template literals minified #178
Conversation
@maxmilton Thoughts? |
Sorry I've been travelling for a while and only just had a bit of time for my projects. Looks good, however is there any notable downside to using |
From my investigation doesn't look like there is any major noted downsides to setting |
…d test to verify module javascript templates are being minified
@maxmilton PR updated to just set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Sorry it took a while but your change has finally been publish in https://github.com/maxmilton/esbuild-minify-templates/releases/tag/v0.8.0 |
At the moment due to defaults in meriyah's parse method javascript with
import
statements are not parsed causing the template literals to not be minified.Updated parse call to always allow parsing of javascript with
import
statements