Bookmark folder popup position not always ideal

[maxmilton]

Now that #1151 is merged we have bookmark folder popup position that is "good enough" for general use but the experience is not ideal in all scenarios.

For context, "top level" means a folder is on the bookmark bar itself and not nested inside another folder.

Folder popup position scenarios

1. Normal/default position
   • Top level: Show below the parent
   • Nested: Show beside the parent (on the right side)
2. Overflowing viewport to the right
   • Top level: Align the popup to the right edge of the viewport
   • Nested: Show beside the parent (on the left side)
     • Subsequent nested folder popups should also open to the left
       • At this point if a popup overflows to the left of the viewport then open to the right of the parent
3. Overflowing viewport both left and right
   • If the viewport is very narrow and the popup overflows on both sides there's basically nothing we can do. In this case the user will need to use the native bookmark bar or bookmark manager.

The current popup position logic from #1151 covers everything other than opening subsequent nested folder popups to the left (and then to the right if overflowing the left edge of the viewport).

Other issues

• Popups remain in place when the parent is scrolled. Native chrome closes the popup upon scrolling the parent, perhaps we should do the same. TBH it's not such a big deal though.

[dror-g]

I'll add that popups open beside the selected item, and if it's a folder near the bottom of the screen - there's no space to display its contents.
Getting a scroller with just one line visible.

[guest271314]

We can now access Bookmarks using side panel on any page so this shouldn't be an issue any more.

[maxmilton]

@guest271314 it's more about having immediate access to the bookmarks on the new tab page and hiding bookmarks elsewhere. In the same vane the native bookmarks bar is available any time, however, there's no way to show and hide it programmatically.

Additionally, I've come to really enjoy this extension's bookmark bar implementation which shows folder on hover. It's really fast and convenient to access bookmarks.

That said, the UI still needs a lot of work. I've been following along with progress on the CSS anchor positioning API and the popover API as potential solutions to reduce the amount of code required compared to all the positioning JS needed.

Refactoring the UI and combustibility are things I'd definitely like to get to soon.

[guest271314]

We can programmatically open the side panel, and provide any content we want there, besides the default list that includes the Bookmarks, here on the extension defined new tab page that I use

We can certainly create an element that is displayed the same window positioning as the native Chromium UI bookmarks panel.

Maybe I'm not getting what you are describing.

[guest271314]

E.g.,