Try based lookup methods #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can add Try... methods to the other lookup types as well if wanted. |
|
Thanks! Please do add them for all the database types along with corresponding unit tests. |
|
Updated. |
| /// <param name="ipAddress">The IP address.</param> | ||
| /// <param name="response">The <see cref="AnonymousIPResponse" />.</param> | ||
| /// <returns>A <see cref="bool" /> describing whether the IP address was found.</returns> | ||
| public bool TryAnonymousIP(string ipAddress, out AnonymousIPResponse response) |
There was a problem hiding this comment.
For some of these, there is only a method that takes a string IP and for others the method takes only an IPAddress. We should have both or at least be consistent.
|
All set now. You're right, I missed some of the methods in that class. Added the missing method overloads, organized the class better so the base methods are at the end and refactored the database reader unit tests too. |
|
Thanks! I merged this and did a beta release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #31
Added new
TryCityandTryCountrymethods that don't throw an exception when the IP address cannot be found. This avoids using exceptions for flow control.