Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIp2Provider doesn't define insights methods #359

Closed
echrisinger opened this issue Oct 3, 2023 · 1 comment · Fixed by #382
Closed

GeoIp2Provider doesn't define insights methods #359

echrisinger opened this issue Oct 3, 2023 · 1 comment · Fixed by #382

Comments

@echrisinger
Copy link

echrisinger commented Oct 3, 2023

Love that you guys package a great client lib. Thanks for the hard work.

One thing that would be useful would be including the insights methods on GeoIp2Provider, or another interface; this makes providing a test double for insights much more easily, as you don't have to wrap WebServiceClient to return a predictable response. We prefer to do this to avoid introducing the complexity of mocking frameworks.

Thanks!
Evan

@oschwald
Copy link
Member

oschwald commented Oct 4, 2023

GeoIp2Provider provider is implemented by bothe the database reader and web service client. The former doesn't have an equivalent to Insights. However, it would make sense to add a WebServiceProvider given that we already have DatabaseProvider for the database reader.

pull bot pushed a commit to CrazyForks/GeoIP2-java that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants