Migrate build facade back to MSBuild #35
Conversation
|
@oschwald, AppVeyor build will fail until VS2017 RTM worker is ready. Currently they have VS2017 RC, which has a bug (can't make benchmark project executable without explicit RID: dotnet/sdk#357 (comment)) If all the rest of (the invasive) changes get approved, we can probably hold off on merging this until AppVeyor shows all green (they said it will happen this week or the next). :) |
am11
force-pushed
the
master
branch
6 times, most recently
from
31b6bdc
to
0c24e2a
Compare
|
Thanks so much for your work on this! 💯 I did a review of the changes, and they seem very reasonable to me. I'll do another pass and some build tests once AppVeyor is updated. |
am11
force-pushed
the
master
branch
2 times, most recently
from
9cd64d3
to
ade1410
Compare
* `dotnet migrate`'d the solution with .NET CLI v1.0.0-RTM.
* Uses to new project system; new CSPROJ schema, which is only
compatible with donet-cli and VS2017 (runs on Windows & Unix)
and xplat VS Code.
* Converted testing framework: nunit -> xunit.
* Frankly speaking, xunit is a first class citizen and most up to
the speed with varied frameworks.
* Using `[Fact]` and `[Theory]` semantics.
* Using `FluentAssertions` to diversify the way of writing assertions.
* Updated the CI scripts.
|
@oschwald, thanks! AppVeyor has VS2017 RTM bits now. I have re-pushed with few more changes (added |
|
Thanks again for all of your work on this! It looks great. |
dotnet migrate'd the solution with .NET CLI v1.0.0-RTM.compatible with donet-cli and VS2017 (runs on Windows & Unix)
and xplat VS Code.
the speed with varied frameworks.
[Fact]and[Theory]semantics.FluentAssertionsto diversify the way of writing assertions.