This repository has been archived by the owner on Jun 3, 2022. It is now read-only.
Support for a http(s) proxy #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2015 23:16
additionally: cleanup HttpClient creation
| systemProxies = true; | ||
| return this; | ||
| } | ||
| public Builder useProxy(String proxyHost, int proxyPort) { |
There was a problem hiding this comment.
Could you change this one to just proxy? use suggests boolean behavior.
|
Thanks! This mostly looks good to me. I had a couple of minor comments. |
|
Thanks! I merged this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into the problem to perform a fraud detection request behind a proxy server and hacked together an extension to the API where you can set the proxy parameters via a
BuilderThoughts and comments are more than welcome.