Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance under scale for 'not found' #11

Closed
mmicco-godaddy opened this issue Jul 26, 2014 · 1 comment
Closed

Performance under scale for 'not found' #11

mmicco-godaddy opened this issue Jul 26, 2014 · 1 comment

Comments

@mmicco-godaddy
Copy link

From documentation:
If an address is not available in the database, a AddressNotFoundException will be thrown.

If you have a hit rate that is high, throwing an exception for an IP city not found would probably be negligble. But, depending on your miss rate, an exception can be an unnecessary overhead expense on your code performance. Should a way to receive a result that indicates 'not found' vs an exception be supported?

@manigandham
Copy link

This is resolved in #50 which adds Try... lookup methods. This follows the idiomatic pattern of other .NET methods like TryParse which use an out parameter for the value and return a bool for the result of the lookup attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants