Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Docker secrets #197

Merged
merged 3 commits into from Jan 16, 2023
Merged

Add support for Docker secrets #197

merged 3 commits into from Jan 16, 2023

Conversation

MattKobayashi
Copy link
Contributor

This PR adds support for Docker secrets, using the well-known _FILE suffix to define the mounted secrets files.

More info: https://earthly.dev/blog/docker-secrets/#using-secrets-with-compose

Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to add documentation for these as well? Thanks!

docker/entry.sh Outdated Show resolved Hide resolved
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@oschwald oschwald merged commit 1d7dafd into maxmind:main Jan 16, 2023
oschwald added a commit that referenced this pull request Jan 16, 2023
shadromani added a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants