Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Issue with Order and Shopping Cart Item Amount #78

Closed
Sn0wCrack opened this issue Jan 29, 2020 · 3 comments
Closed

Validation Issue with Order and Shopping Cart Item Amount #78

Sn0wCrack opened this issue Jan 29, 2020 · 3 comments

Comments

@Sn0wCrack
Copy link

According to the minFraud API documentation the Order and Shopping Cart endpoints both state "The value must be at least 0 and at most 1e14 – 1."

However it appears this library validates for at least 1 due to the following line:

v::key('amount', v::floatVal()->min(0, false), false),

Which validates from a minimum of 0 non-inclusive.

Just to clarify, is the documentation correct in stating that a 0 amount is acceptable to send through to the API?

@oschwald
Copy link
Member

Thanks for reporting this. The documentation is correct that 0 is acceptable. I have fixed the API in #80.

PatrickCronin added a commit that referenced this issue Feb 13, 2020
Update amount validation to match web service. Closes #78
@Sn0wCrack
Copy link
Author

Thanks a lot of fixing that, is there any ETA on this getting into a new package version?

@oschwald
Copy link
Member

We just did a release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants