Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ACCOUNT_ID_REQUIRED error and update some text #8

Merged
merged 2 commits into from
Feb 26, 2018

Conversation

oschwald
Copy link
Member

MaxMind is renaming "user ID" to "account ID" for basic auth as we roll out multi-user accounts. In doing this, we will be updating the error code returned by the service from USER_ID_REQUIRED to ACCOUNT_ID_REQUIRED. This PR supports both the new and old error code. It also updates some references to "user ID". It does not change change the accessor on Minfraud as I was not sure how you wanted to handle that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.347% when pulling f318da1 on oschwald:greg/account-id into 6b97c5d on kushniryb:master.

@kushniryb
Copy link
Contributor

Hello @oschwald
Thank you, this is great 👍
I suppose we'll go with user_id for now so that it's compatible with both versions.

@kushniryb kushniryb merged commit 0d42edc into maxmind:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants