Adding ability to specify bind address for NATS address #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing down changes to only specify bind address.
Old given that Marmot can now boot embedded NATS withdns://<DNS_ENTRIES:<port>/to effectivenats://<resolved_ip>:<port>for multiple entries, and actually wait for minimum number of nodes to come up before it proceeds, it was very obvious next step to automatically add/remove these entries from NATs server in background. This PR lays down foundation to do that in a dynamic way, so that cluster membership can be elastic based on DNS discovery.NOTE Turns out the NATS configuration can't be reloaded in disk persistent mode which is core requirement for Marmot flows. In order to keep the good parts I am using this PR to strip extra stuff off and only keep couple of things I fixed while fixing PR.