Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #977

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Develop #977

merged 3 commits into from
Jan 26, 2024

Conversation

katsikora
Copy link
Contributor

No description provided.

@katsikora
Copy link
Contributor Author

I had to drop the speedup version as it resulted in the package not being included in the build and snakePipes erroring out later on.

@WardDeb
Copy link
Member

WardDeb commented Jan 26, 2024

Does this also warrant the same change in the action env ? (snakePipesEnvCI.yml)

@katsikora
Copy link
Contributor Author

Does this also warrant the same change in the action env ? (snakePipesEnvCI.yml)

Good question... The tests ran through, so I guess this can be now left as is. I wonder if it's the difference in python version, or in the solver. The GHA workflow uses micromamba, I'm using conda build locally.
There is also a difference in the channels, I'll test briefly if adding defaults would fix the build issue.
Thanks for your help 🙏

@katsikora
Copy link
Contributor Author

Running conda build -c conda-forge -c bioconda -c defaults conda-recipe instead of conda build -c conda-forge -c bioconda conda-recipe doesn't solve the issue, I still get ModuleNotFoundError: No module named 'thefuzz' Tests failed for snakepipes-2.8.0-py_0.tar.bz2 .

I'll go ahead with the PR then.

@katsikora katsikora merged commit fa34318 into master Jan 26, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants