Another batch of improvements :)

[guizmaii]

And @sderosiaux worked on simplifying your GameResult.collectRegion function.

He'll push you a PR too ;)

(as usual, can you please squash my commits ? thanks 🙂)

[guizmaii]

is it normal that we pass (point._1, point._1) to neighborMap here ?

[maxpumperla]

omg, no! good catch.

[guizmaii]

Would like me to fix this or you'll fix it ?

[sderosiaux]

Thanks @guizmaii. Here it is #10.

[sderosiaux]

FYI @guizmaii the best way here would be to import cats: territoryMap.values.foldMap(t => Map(t -> 1)) (it uses the Int Monoid and return a Map[Type, Int]), and probably use cats in more places.

[maxpumperla]

@guizmaii @sderosiaux let's leave cats out, please. You might see this differently, but it's often the beginning of the end of a project's readability :)

[sderosiaux]

Sure @maxpumperla, no worries.

[guizmaii]

@sderosiaux thanks ! I didn't know that :) but as requested, I'll not add Cats ;)

[maxpumperla]

@guizmaii assuming you continue your refactoring odyssee, would you mind branching off of current master? 👍

[guizmaii]

@maxpumperla It's my last PR. I'll not have any more time to spend on this project until a long time. I have a lot more work to do on other projects.

I hope that these PRs were useful to you. If you have any question on Scala or FP you can always contact me on Twitter.

It was fun to work on your project. I don't know the Go game and discovered some rules by reading the code. 🙂

Again, I don't want to be cocky but here some advices about your use of Scala:

1. try to avoid mutability as much as possible. It'll ease the understanding of your work to others and it'll help you not to implement bugs.
2. Scala is a strongly typed programming language and you should take advantage of that. For example, if the col and row were fully typed, the (point._1, point._1) bug could not have existed.

You can always declare "value classes" (https://docs.scala-lang.org/overviews/core/value-classes.html) to express the exact domain of your program.
For example, you're not working with Ints but with Rows and Columns. So, you can express that fact in your program thanks to value classes:

final case class Row(value: Int) extend AnyVal
final case class Col(value: Int) extend AnyVal

Because they are value classes, they don't bring runtime overhead but only brings you type safety and accuracy when you code.

Maybe you already know all that, I don't know. I talk only on what I saw in your code.

Thanks for the time you spent reviewing my PRs 🙂

[guizmaii]

could be improved:

! friendlyStrings.exists(_.numLiberties != 1)