Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript type definitions #30

Closed
wants to merge 2 commits into from
Closed

Conversation

sgmccli
Copy link

@sgmccli sgmccli commented Oct 18, 2017

This pull request provides type definitions for the parent-package-json module. This allows it to be easily integrated with the TypeScript programming language.

@maxrimue
Copy link
Owner

Thanks for the pr. I appreciate you putting time into this, however, I don't see much value in adding definitions to little projects like this one. Sindre Sorhus, who I share my opinion with, put it like this:

I use neither TypeScript nor Flow in my small modules as I don't yet see enough value. If I were to
accept type definitions, I would have to maintain them. Which I would do badly. I would say bad
definitions are worse than none. DefinitelyTyped and flow-typed are good solutions to this problem.
Submit the type definitions there instead.

See the comment here

@maxrimue maxrimue closed this Oct 19, 2017
@sgmccli
Copy link
Author

sgmccli commented Oct 19, 2017

Ok fair enough. I have submitted a PR on DefinitelyTyped.

@maxrimue
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants