Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package react-native-spinkit has been ignored during build with RN 0.60.4 #124

Open
heikir opened this issue Jul 23, 2019 · 8 comments
Open

Comments

@heikir
Copy link

heikir commented Jul 23, 2019

When building my project with RN 0.60.4 and react-native-spinkit 1.4.0 I get the following warning:

warn Package react-native-spinkit has been ignored because it contains invalid configuration. Reason: "commands" must be an array

@sboyd17
Copy link

sboyd17 commented Jul 24, 2019

I have the same problem in my app!

My temporary fix is:

  1. yarn remove react-native-spinkit or npm uninstall --save react-native-spinkit
  2. yarn add react-native-spinkit@1.3.0 or npm install --save react-native-spinkit@1.3.0

Does anyone else have a more permanent solution as this will only last until the next release?

@ChauVV
Copy link

ChauVV commented Jul 24, 2019

I have the same problem!

@Elvinra
Copy link

Elvinra commented Jul 24, 2019

On the folder node_modules/react-native-spinkit.
Delete the file react-native.config.js
After that add on the file android/build.gradle

allprojects { repositories { ... // ADD THIS maven { url "https://jitpack.io" } } }

edcrampin added a commit to edcrampin/react-native-spinkit that referenced this issue Jul 24, 2019
react-native.config.js had the commands array as an object. This has been resolved. Fixes issue maxs15#124
@edcrampin
Copy link
Contributor

PR opened to fix this - #125

@sboyd17
Copy link

sboyd17 commented Jul 28, 2019

Will this patch be merged into the master branch? I have to keep copying the patch into the files every time that I install a new package to add to my app to avoid getting the error.

PR opened to fix this - #125

@edcrampin
Copy link
Contributor

PR now has been merged in... fixed in v1.4.1 of react-native-spinkit 🎉

@ziaulrehman40
Copy link

If it is merged, why is issue not closed?

It makes bad impact to see this much issues open.

@stephanoparaskeva
Copy link

getting issue on 1.5.0

maxs15 pushed a commit that referenced this issue Oct 4, 2020
react-native.config.js had the commands array as an object. This has been resolved. Fixes issue #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants