Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch 'compile' to 'implementation' #120

Merged
merged 1 commit into from Jul 21, 2019
Merged

Conversation

tethridge
Copy link
Contributor

This is a fix for the warning message shown when syncing
Gradle. The warning is:

WARNING: Configuration 'compile' is obsolete and has been
replaced with 'implementation' and 'api'. It will be removed
at the end of 2018.

See: #119

This is a fix for the warning message shown when syncing
Gradle. The warning is:

WARNING: Configuration 'compile' is obsolete and has been
replaced with 'implementation' and 'api'. It will be removed
at the end of 2018.

See: maxs15#119
@Xesme
Copy link

Xesme commented Jun 20, 2019

Can this be merged in? I am experiencing this issue as well.

@hansfpc
Copy link

hansfpc commented Jun 28, 2019

Nice

@majid-vaghari
Copy link

No updates? :-?

@andrewsadowski
Copy link

It would be super great if this PR could be merged in. Hitting this problem as well.

@cxrod
Copy link

cxrod commented Jul 3, 2019

Please @maxs15 can you merge this and bump a new npm version?

@GreanBeetle
Copy link

Any chance this will be merged soon?

mylylyl added a commit to mylylyl/react-native-spinkit that referenced this pull request Jul 16, 2019
@maxs15 maxs15 merged commit f6c0824 into maxs15:master Jul 21, 2019
@maxs15
Copy link
Owner

maxs15 commented Jul 21, 2019

Thanks @tethridge 👍

maxs15 added a commit that referenced this pull request Oct 4, 2020
Switch 'compile' to 'implementation'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants