Remove rnpm and add react-native config file #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mylylyl
approved these changes
Jul 15, 2019
mylylyl
added a commit
to mylylyl/react-native-spinkit
that referenced
this pull request
Jul 16, 2019
mylylyl
added a commit
to mylylyl/react-native-spinkit
that referenced
this pull request
Jul 16, 2019
|
Thanks @FelipePaiva1992, merging it 👍 |
maxs15
added a commit
that referenced
this pull request
Oct 4, 2020
Remove rnpm and add react-native config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build my app using this dependence the CLI return me this warning:
The following packages use deprecated "rnpm" config that will stop working from next release: react-native-spinkit: https://npmjs.com/package/react-native-spinkitPlease notify their maintainers about it. You can find more details at https://react-native-community/cli/docs/configuration.md#migration-guide.
This PR it`s basically this update