Update for latest React Native, Spinkit Android dependency and TS support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roidx.annotation.Nullable
radko93
changed the title
|
@maxs15 I would appreciate merging this, we would get this repo back on track |
|
Amazing work! Thanks @radko93, I'll merge that |
maxs15
added a commit
that referenced
this pull request
Oct 4, 2020
Update for latest React Native, Spinkit Android dependency and TS support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined all the fixes and upgraded Spinkit if someones interested. Everything seems to work as on React Native 0.60.6 on iOS & Android. Also integrated TS types thanks to @nartc @steffenagger
fixes #105, fixes #126, fixes #119, fixies #96, fixes #106
PRs that do similar things: closes #128, closes #127, closes #103, closes #101
You can use my fork if this does not get merged.