Options and printing #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxscheurer
force-pushed
the
modern_options
branch
2 times, most recently
from
bae82a6
to
85bfec5
Compare
maxscheurer
force-pushed
the
modern_options
branch
from
85bfec5
to
dcaab91
Compare
maxscheurer
force-pushed
the
modern_options
branch
from
f077633
to
485dea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a more modern option implementation, making it easier to add new options➡️ postponeand exposing them to the Python layer.
Note: The current code requires C++17. However, there should be some solution for backward compatibility implemented...std::functionfrom C++/Python layer to customize print-out)