Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 #42

Closed
wants to merge 4 commits into from
Closed

Swift 3 #42

wants to merge 4 commits into from

Conversation

noxt
Copy link

@noxt noxt commented Sep 16, 2016

#41 issue

@OdNairy
Copy link

OdNairy commented Sep 20, 2016

I love this change:
from:
class TableRowActionData<ItemType, CellType: ConfigurableCell where CellType.T == ItemType, CellType: UITableViewCell>

to:
class TableRowActionData<CellType: ConfigurableCell> where CellType: UITableViewCell>

@OdNairy
Copy link

OdNairy commented Oct 3, 2016

Update IOS_SDK from iphonesimulator9.3 to iphonesimulator10.0

@maxsokolov
Copy link
Owner

So, guys,

I've provided Swift 3.0 support, also available via Cocoapods. I can't accept this PR, because I see several breaking changes. Some of them was discussed here. The first generic parameter of TableRow is still actively used in several projects that I've involved to.

@maxsokolov maxsokolov closed this Oct 3, 2016
@maxsokolov maxsokolov mentioned this pull request Oct 3, 2016
@OdNairy OdNairy mentioned this pull request Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants