Merging mainline coffee #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In for example `for` loops, a variable called `i` is generated (for the loop index). If that name is unavailable, `j` is used instead, then `k`, `l`, etc. all the way to `z`. Then, `aa`, `ab`, `ac` etc. are used. This meant that, eventually, `do` would be used, but that's not a valid variable name since `do` is a JavaScript keyword. This logic was also inefficiently implemented. For example, going from `aa` to `ab` or from `az` to `ba` required lots of loop iterations. This commit changes the variable naming convention. Now, `i`, `j`, `k`, etc. to `z` are used like before. Then comes `i1`, `j1`, `k1`, etc. Then `i2`, `j2`, `k2` and so on. This is simpler, efficient and easier to understand. `i1` is more obvious to be a loop index than `aa`. Fixes jashkenas#4267.
Improve naming of generated 'i-variables'
Fix misspellings
|
👍 Thank you! |
|
Let me know if you want me to do some more here :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fresh ☕
Not too many changes though.