Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging coffee-script 1.11 release #194

Merged
merged 2 commits into from
Oct 6, 2016
Merged

Conversation

zapu
Copy link
Collaborator

@zapu zapu commented Oct 5, 2016

Biggest change is import/export syntax from ES6. Important to note is that coffee/iced does not do any module resolving, it will just emit correct JavaScript import/export code.

All tests pass, but I haven't get a chance to try all the new features. Import/export seems to work though (compiles fine). It won't work in when ran in node, because node itself does not support ES6 modules.

A relatively big pull request, because it includes all coffeescript compiles. Iced compilation output files are not included, though.

Biggest change is import/export syntax from ES6. Important to note is
that coffee/iced does not do any module resolving, it will just emit
correct JavaScript import/export code.
@maxtaco
Copy link
Owner

maxtaco commented Oct 5, 2016

👍 Should I go ahead and merge it?

@zapu
Copy link
Collaborator Author

zapu commented Oct 5, 2016

I can also add the compiled output of iced, or you can do it using the release script. Other than that, the merge itself is done :)

@zapu
Copy link
Collaborator Author

zapu commented Oct 5, 2016

BTW I also have a branch with Travis CI enabled. I wanted to try it and was curious what was it all about. It pretty much just runs icake3 test, but it can do it on multiple different node versions. So this already shows some issues with node that was released about just a year ago.

https://travis-ci.org/zapu/coffeescript

It should be fairly easy to set this up on the main repo. I'm unsure whether you have to link your account to travis-ci.org or not - this is my biggest complaint, seems fairly invasive. I'd rather be told some webhook URLs to enter, instead of giving my entire account.

@maxtaco
Copy link
Owner

maxtaco commented Oct 6, 2016

Super busy today but I managed to flip the switch on travis to turn on coffee-script repo

@zapu
Copy link
Collaborator Author

zapu commented Oct 6, 2016

Thanks! Can you merge this one? Then I can make a PR with the travis config and some minor test fixes.

@maxtaco maxtaco merged commit eaaa449 into maxtaco:iced3 Oct 6, 2016
@zapu zapu mentioned this pull request Oct 27, 2016
@zapu zapu deleted the coffee-1-11 branch May 12, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants