Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows you to filter TimeEntry with parameters from_date and to_date #3

Merged
merged 1 commit into from Jan 26, 2014

Conversation

aaloy
Copy link
Contributor

@aaloy aaloy commented Jan 25, 2014

as the spend_on parameter and others filters does not work, I've checked what redmine does in the web and added the same parameters. As from is a reserved word I've changed to from_date and to_date to be more clear.

Actually this allows you to filter TimeEntries in an range of days.

the spend_on parameter and others filters does not work.
@maxtepkeev maxtepkeev merged commit e11556e into maxtepkeev:master Jan 26, 2014
@maxtepkeev
Copy link
Owner

Thanks!

I've checked that from/to also works in Redmine 2.3.x and should also work in 2.4.x. So I believe this should be a preferred way to retrieve time entries for a range of dates.

Because that was a specific time entry problem I removed the kwargs substitution from Redmine.request and introduced a new Resource.translate_params class method which is now responsible for translation of params per resource if needed. This will allow us to easily translate parameters per resource if needed in the future.

@ghost ghost assigned maxtepkeev Jan 26, 2014
@aaloy
Copy link
Contributor Author

aaloy commented Jan 26, 2014

great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants