Make Redmine class picklable
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rconradharris
force-pushed
the
make-redmine-picklable
branch
from
8b0e18b
to
925a7bc
Compare
|
Changes Unknown when pulling 925a7bc on rconradharris:make-redmine-picklable into * on maxtepkeev:master*. |
|
Changes Unknown when pulling 925a7bc on rconradharris:make-redmine-picklable into * on maxtepkeev:master*. |
rconradharris
force-pushed
the
make-redmine-picklable
branch
from
925a7bc
to
bececf5
Compare
|
Changes Unknown when pulling bececf5 on rconradharris:make-redmine-picklable into * on maxtepkeev:master*. |
The `Redmine` class couldn't be pickled because the `gettatr` would attempt to turn any attribute access into a `Resource`, even `__getstate__`. The proposed fix treats attributes that begin with an underscore (and double-underscore) as non-`Resource` attributes. Fixes maxtepkeev#64
rconradharris
force-pushed
the
make-redmine-picklable
branch
from
bececf5
to
34b081a
Compare
|
Changes Unknown when pulling 34b081a on rconradharris:make-redmine-picklable into * on maxtepkeev:master*. |
maxtepkeev
added a commit
that referenced
this pull request
Nov 5, 2014
Make `Redmine` class picklable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Redmineclass couldn't be pickled because thegettatrwould attempt toturn any attribute access into a
Resource, even__getstate__.The proposed fix treats attributes that begin with an underscore (and
double-underscore) as non-
Resourceattributes and returns their value as-is.Fixes #64