New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for existing Check: DeclarationOrder #4
Comments
new option should be provided - "boolean groupOverloadMethods" |
Change to "If true, avoid splitting overload methods"
Use parentType instead of parentNode as it was before
Bad name and description. This method doesn't group anything it just checks for ...
I don't understand this name
Avoid magic numbers |
Also update xdocs |
can't make up any good name. Please, help. |
The rest is done, check my commit. |
Should be "Checks that overload methods are grouped together.
Should be "checkGroupingOfOverloadMethods" or "checkOverloadMethodsGrouping" or any other ideas..
Program to interfaces instead of their implementations
Change name to "currentIndex"
Change name to "methodIndexMap" |
Can't use primitive, because sometimes The rest is done. |
Change to "An example of a check's configuration for grouping overload methods"
Change to "Checks that if overload methods are grouped together they should not be separated from each other"
Change to "Overload methods should not be split"
Change to "testOverloadMethodsGrouping" |
Where did you find it? I don't understand.. |
|
looks good, but please make
make it as value="true" in both files(java and xml)
What is the reason of inner tag "
|
|
ok, good, this update is ready for PullRequest(PR) - please do. |
Merged |
Update existing Check to cover next rule: http://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s3.4.2.1-overloads-never-split
The text was updated successfully, but these errors were encountered: