Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty "hidden" card still takes up space #521

Closed
ScottG489 opened this issue Jan 1, 2023 · 2 comments
Closed

Empty "hidden" card still takes up space #521

ScottG489 opened this issue Jan 1, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@ScottG489
Copy link

Describe the bug
Card still takes up a small amount of space when it should be hidden. I believe we should apply a display: none style to the card. It looks like this was partially implemented with #360 to fix #359 (where I left a related comment).

How to reproduce
Create a card that has no displayed battery entities. It takes up a small amount of space due to margins (see screenshots below).

Expected behavior
Card should not only be hidden, but take up no space.

YAML configuration
N/A

Screenshots
auto-entities for comparison:

Screen Shot 2022-12-23 at 12 53 57 PM

You can see the battery card next to another card with the element highlighted in dev tools:

Screen Shot 2022-12-23 at 12 55 11 PM

That part highlighted in orange is due to a 4 pixel margin on the top and bottom. Small nitpick of course, but it adds a noticeable gap when nested between other cards.

Version
v2.1.1

@ScottG489 ScottG489 added the bug Something isn't working label Jan 1, 2023
@maxwroc
Copy link
Owner

maxwroc commented Jan 2, 2023

Thanks for details. Indeed this could be fixed/improved

@maxwroc
Copy link
Owner

maxwroc commented Oct 21, 2023

Fixed in v3

@maxwroc maxwroc closed this as completed Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants