Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks other libraries depending on aiohttp #6

Closed
AlexExarhos opened this issue Nov 12, 2020 · 1 comment
Closed

Breaks other libraries depending on aiohttp #6

AlexExarhos opened this issue Nov 12, 2020 · 1 comment

Comments

@AlexExarhos
Copy link

See this line:

# Patch ClientResponse.read to release immediately after read so we don't need to worry about that / use context manager

Patching the 'ClientResponse.read' will break other libraries that depend on its behavior. My project was also using aioboto3, which led to ClientDisconnect errors.

@AlexExarhos AlexExarhos changed the title Breaks other libraries depending Breaks other libraries depending on aiohttp Nov 12, 2020
@maxzheng
Copy link
Owner

Removed monkey patching as it is not absolutely necessary -- it seems to close by itself after reading to EOF or later during garbage collection now. Published change as 0.2.0. Try it and let me know if you still run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants