Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks aiodocker because of monkey patching aiohttp #7

Closed
AndreaCensi opened this issue Apr 23, 2022 · 1 comment
Closed

Breaks aiodocker because of monkey patching aiohttp #7

AndreaCensi opened this issue Apr 23, 2022 · 1 comment

Comments

@AndreaCensi
Copy link

Similar to the preceding issue #6, this library breaks aiodocker.
More details here: aio-libs/aiodocker#706
@maxzheng
Copy link
Owner

Removed monkey patching as it is not absolutely necessary -- it seems to close by itself after reading to EOF or later during garbage collection now. Published change as 0.2.0. Try it and let me know if you still run into problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreaCensi @maxzheng