chore(log): adding higher latency log per IO #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishnu Itta <vitta@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## v0.8.x #184 +/- ##
==========================================
- Coverage 52.41% 52.22% -0.19%
==========================================
Files 240 240
Lines 78049 78057 +8
==========================================
- Hits 40906 40766 -140
- Misses 37143 37291 +148Continue to review full report at Codecov.
|
pawanpraka1
reviewed
Jan 7, 2019
| @@ -41,6 +41,7 @@ | |||
|
|
|||
| #define MAXEVENTS 64 | |||
|
|
|||
| #define IO_THRESHOLD_TIME 30 | |||
There was a problem hiding this comment.
30 sec is too much for a single IO. can we set it to 5 sec ?
vishnuitta
added a commit
to vishnuitta/zfs
that referenced
this pull request
Jan 30, 2019
When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue. This PR is to logs at uZFS layer regarding high latent IOs. Signed-off-by: Vishnu Itta <vitta@mayadata.io>
vishnuitta
added a commit
that referenced
this pull request
Feb 13, 2019
When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue. This PR is to logs at uZFS layer regarding high latent IOs. Signed-off-by: Vishnu Itta <vitta@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replica gets disconnected with target due to timeout, there might be some IOs that are not responded for long time. There are ZIO delay logs that helps in debugging this issue.
This PR is to logs at uZFS layer regarding high latent IOs.
Signed-off-by: Vishnu Itta vitta@mayadata.io