fix: remove format extension for public-id #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Issue #22, i.e. publicId getting malformed in case it contains "."-char other than as part of extension
Technical note
I removed it completely because I think it is not taking effect anyways, due to the explicit "f_[format]" transformation that is applied later on (https://github.com/mayashavin/cloudinary-api/blob/main/packages/url/lib/url.ts#L127)
E.g., If I take the url from the sample
even with auto-format (aka
f_auto
) this will result in content-typeimage/web_p
being downloaded in most modern browsers, despite the.jpg
extension that is part of thepublicID
.From my understanding the file-extension is only taken under consideration if there is no format-option present, wich will never be the case here?