Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove format extension for public-id #23

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

chunksnbits
Copy link
Contributor

Resolves

Issue #22, i.e. publicId getting malformed in case it contains "."-char other than as part of extension

Technical note

I removed it completely because I think it is not taking effect anyways, due to the explicit "f_[format]" transformation that is applied later on (https://github.com/mayashavin/cloudinary-api/blob/main/packages/url/lib/url.ts#L127)

E.g., If I take the url from the sample

even with auto-format (aka f_auto) this will result in content-type image/web_p being downloaded in most modern browsers, despite the .jpg extension that is part of the publicID.

image

From my understanding the file-extension is only taken under consideration if there is no format-option present, wich will never be the case here?

@mayashavin
Copy link
Owner

Looks great. Thanks for contributing ❤️ and sorry for the late review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants