Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build "notification" UI #447

Closed
Shpigford opened this issue Feb 12, 2024 · 10 comments · Fixed by #449
Closed

Build "notification" UI #447

Shpigford opened this issue Feb 12, 2024 · 10 comments · Fixed by #449
Labels
💎 Bounty 💰 Rewarded

Comments

@Shpigford
Copy link
Member

Shpigford commented Feb 12, 2024 •
edited
Loading

This issue is for the creation of a system-wide "notification" UI. It replaces the typical "flash" messages in Rails.

These are temporary notifications that show and disappear after 5 seconds.

Scope

  1. "Success" notification
  2. "Error" notification
  3. 5 second delay before disappearing (uses the "loading" icon in the Figma file)
  4. Dismissible by clicking on the notification

Design

Figma file: https://link.maybe.co/figma-notification

CleanShot 2024-02-12 at 10 44 13@2x

CleanShot 2024-02-12 at 10 44 28@2x

Bounty

There is a $50 bounty on this. To participate in the bounty:

  1. Comment /attempt #447 to indicate you plan on working on this.
  2. Submit a draft PR once you start and include /claim #447 along with your general gameplan for how you intent to implement this.
  3. Change out of draft mode on the PR once you're ready to submit your attempt.

In the event of multiple attempts, we generally pick the one that most closes matches the scope with the cleanest code and test coverage (when appropriate).
@Shpigford
Copy link
Member Author

/bounty $50

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 12, 2024 •
edited
Loading

💎 $50 bounty created by maybe-finance
🙋 If you start working on this, comment /attempt #447 along with your implementation plan
👉 To claim this bounty, submit a pull request that includes the text /claim #447 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to maybe-finance/maybe!

👉 Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @ibishal Feb 12, 2024, 4:50:30 PM WIP
🟢 @adelinaenache Feb 12, 2024, 4:51:55 PM WIP
🟢 @mogery Feb 12, 2024, 4:55:01 PM #448
🔴 @crolla97 Feb 12, 2024, 5:33:23 PM WIP
🟢 @HawtinZeng Feb 13, 2024, 1:11:08 AM WIP
🟢 @JoshAntBrown #449
🟢 @jclusso #455

@ibishal
Copy link

ibishal commented Feb 12, 2024 •
edited by algora-pbc bot
Loading

/attempt #447

Algora profile Completed bounties Tech Active attempts Options
@ibishal 1 bounty from 1 project
TypeScript, Scala,
Rust
Cancel attempt

@adelinaenache
Copy link

adelinaenache commented Feb 12, 2024 •
edited by algora-pbc bot
Loading

Hey, new here here! Nice to meet you all:) Would like to attempt this. I can start this in 2-3 hours so that's that. /attempt #447

Algora profile Completed bounties Tech Active attempts Options
@adelinaenache 3 bounties from 1 project
JavaScript, Python,
TypeScript & more
Cancel attempt

@mogery
Copy link

mogery commented Feb 12, 2024 •
edited by algora-pbc bot
Loading

/attempt #447

Algora profile Completed bounties Tech Active attempts Options
@mogery 19 bounties from 5 projects
Rust, TypeScript,
HTML & more
Cancel attempt

@crolla97
Copy link
Contributor

crolla97 commented Feb 12, 2024 •
edited by algora-pbc bot
Loading

/attempt #447

@Shpigford No access to the Figma file fyi

Algora profile Completed bounties Tech Active attempts Options
@crolla97    1 maybe-finance bounty
+ 0 bounties from 0 projects
JavaScript, Ruby
Cancel attempt

@Shpigford
Copy link
Member Author

Sorry about the Figma file, folks! It should work now.

@mogery mogery mentioned this issue Feb 12, 2024
Closed
@JoshAntBrown JoshAntBrown mentioned this issue Feb 12, 2024
Merged
@HawtinZeng
Copy link

/attempt #447

jclusso added a commit to jclusso/maybe that referenced this issue Feb 13, 2024
@jclusso
Add Notifications UI
9a612c5 
Resolves maybe-finance#447
/claim maybe-finance#447

Some key things to note:

- Adds notifications UI
- This implementation supports both flash on redirects (ex: `redirect_to(root_path, alert: "Something went wrong")` as well as flash on turbo stream responses (ex: `turbo_stream.flash(alert: "Something went wrong")`)
- Replaces flash helper in auth views
@jclusso jclusso mentioned this issue Feb 13, 2024
Closed
jclusso added a commit to jclusso/maybe that referenced this issue Feb 13, 2024
@jclusso
Add Notifications UI
09d8c16 
Resolves maybe-finance#447
/claim maybe-finance#447

Some key things to note:

- Adds notifications UI
- This implementation supports both flash on redirects (ex: `redirect_to(root_path, alert: "Something went wrong")` as well as flash on turbo stream responses (ex: `turbo_stream.flash(alert: "Something went wrong")`)
- Replaces flash helper in auth views
jclusso added a commit to jclusso/maybe that referenced this issue Feb 13, 2024
@jclusso
Add Notifications UI
f13482b 
Resolves maybe-finance#447
/claim maybe-finance#447

Some key things to note:

- Adds notifications UI
- This implementation supports both flash on redirects (ex: `redirect_to(root_path, alert: "Something went wrong")` as well as flash on turbo stream responses (ex: `turbo_stream.flash(alert: "Something went wrong")`)
- Replaces flash helper in auth views
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 13, 2024

🎉🎈 @JoshAntBrown has been awarded $50! 🎈🎊

@Shpigford
Copy link
Member Author

Thanks everyone for the work on this! Went with #449 as it was the right balance of "thorough" and "simple".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty 💰 Rewarded
Projects
None yet
Milestone
No milestone
6 participants
@Shpigford @adelinaenache @crolla97 @mogery @HawtinZeng @ibishal