Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines problem in non .php files #4

Closed
voidus opened this issue Jul 6, 2011 · 0 comments
Closed

Empty lines problem in non .php files #4

voidus opened this issue Jul 6, 2011 · 0 comments

Comments

@voidus
Copy link

voidus commented Jul 6, 2011

=========================== royjs wrote====================================
Hi,

I have a small problem where errors don't appear on the right line due to missing empty lines in my files.
E.g.

echo ('test');

appears as

in CodeBrowser, so errors appear on the wrong line. I found this Issue https://github.com/mayflowergmbh/PHP_CodeBrowser/issues/40 wich seems to be related but is the opposite problem (too many empty lines). I changed if ('.php' === $extension {if ('.php' === $extension || '.module' === $extension || '.inc' === $extension) {
on line 335 of ViewReview.php and it fixes the problem. Would it be a good idea to add a parameter allowing us to tell phpcb with extension to parse as a PHP file ?
@voidus voidus closed this as completed Jul 6, 2011
@voidus voidus reopened this Jul 6, 2011
@voidus voidus closed this as completed in d444444 Jul 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant