Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions and remove Travis #193

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Jan 21, 2022

Type of PR

  • Bugfix
  • New Feature
  • Other (explain):

Use GitHub Actions as CI

Breaking changes

  • Yes, this is a breaking change

Description

We want to use GitHub Actions in the future

@xalopp xalopp marked this pull request as draft January 21, 2022 09:31
@xalopp xalopp force-pushed the use_gha branch 4 times, most recently from 10e0f2c to e16ffb9 Compare January 21, 2022 16:20
@xalopp xalopp marked this pull request as ready for review January 21, 2022 16:28
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #193 (1196a7b) into master (541db46) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #193   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       150       150           
===========================================
  Files              8         8           
  Lines            568       611   +43     
===========================================
+ Hits             568       611   +43     
Impacted Files Coverage Δ
MO4/Sniffs/Arrays/MultiLineArraySniff.php 100.00% <0.00%> (ø)
MO4/Sniffs/Commenting/PropertyCommentSniff.php 100.00% <0.00%> (ø)
MO4/Sniffs/WhiteSpace/ConstantSpacingSniff.php 100.00% <0.00%> (ø)
...4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php 100.00% <0.00%> (ø)
...iffs/Formatting/UnnecessaryNamespaceUsageSniff.php 100.00% <0.00%> (ø)
...iffs/Strings/VariableInDoubleQuotedStringSniff.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541db46...1196a7b. Read the comment docs.

@xalopp
Copy link
Contributor Author

xalopp commented Jan 21, 2022

@mmoll happy?

@xalopp xalopp marked this pull request as draft January 22, 2022 18:31
@xalopp xalopp force-pushed the use_gha branch 3 times, most recently from 2a9f23d to 061d221 Compare January 22, 2022 19:55
@xalopp xalopp marked this pull request as ready for review January 22, 2022 21:24
@xalopp
Copy link
Contributor Author

xalopp commented Jan 22, 2022

@mmoll the slack integration isn't yet working because of Settings - Actions secrets:

Secrets are not passed to workflows that are triggered by a pull request from a fork. Learn more. 

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
xalopp and others added 4 commits January 25, 2022 18:59
Co-authored-by: Michael Moll <kvedulv@kvedulv.de>
Co-authored-by: Michael Moll <kvedulv@kvedulv.de>
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@mmoll mmoll changed the title Use GitHub Actions Use GitHub Actions and remove Travis Jan 25, 2022
@mmoll mmoll merged commit 12e4004 into mayflower:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants