Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Footer mode does not stretch iframe card to bottom of screen #258

Closed
blhoward2 opened this issue Aug 28, 2020 · 5 comments
Closed

Footer mode does not stretch iframe card to bottom of screen #258

blhoward2 opened this issue Aug 28, 2020 · 5 comments
Assignees
Labels
Bug Something isn't working

Comments

@blhoward2
Copy link

blhoward2 commented Aug 28, 2020

When displaying a website in a full-screen iframe, using compact mode and footer mode, the iframe draws to where it would if compact mode was not on and the space was left blank. When footer mode is not on the card correctly fills the screen. When compact mode is turned off everything looks as it should. Verified in both Chrome and Fully Kiosk Browser. Using the latest stable home assistant and the latest custom-header.

Raw configuration:

custom_header:
  compact_mode: true
  disable_sidebar: true
  exceptions: []
  shadow: false
  footer_mode: true
views:
  - background-image: center / cover no-repeat fixed url('/local/blue-abstract.jpg')
    badges: []
    cards:
      - aspect_ratio: 50%
        style: |
          ha-card {
            height: 100%
            width: 100%
          }
        type: iframe
        url: 'http://192.169.0.123/'
    icon: 'mdi:home-outline'
    panel: true

Screen Shot 2020-08-27 at 11 51 45 PM

@blhoward2 blhoward2 added the Bug Something isn't working label Aug 28, 2020
@github-actions
Copy link

Important:

Issues that don't provide the necessary information listed below may not get a reply and will be closed until the info is provided.

Release is the current version of Custom Header. Be sure that you are using the latest version by checking your browser's dev tools console (usually found by pressing F12). If this doesn't display the current version either clear your cache or reinstall.

If you haven't yet done so, please read the "Before Posting an Issue" section of the docs site.

Include as much of the following info as you can to help me replicate and investigate your issue:

  • A copy/paste of your Custom Header config (found in "Raw Config Editor" or ui-lovelace.yaml).
    Use the tip at the end of this post to format it correctly.
  • Any errors relevant to Custom Header found in the HA logs
  • Any relevant errors found in your browsers dev console (F12)
  • The version of Home Assistant and Custom Header you are using
  • The browsers or apps that are affected (i.e. Firefox, Chrome, Chrome Mobile, iOS HA Companion app, etc.)
  • Installation method (HACS or manual)
  • Lovelace Mode (YAML or Storage). If you are unsure, you are most likely using Storage.

When pasting in your config always place 3 backticks ``` above the first line of your config and after the last line. Doing this will format it correctly so that I may find any formatting errors in your config.

@maykar maykar self-assigned this Aug 28, 2020
@maykar
Copy link
Owner

maykar commented Aug 29, 2020

In the next update I will fix the extra padding at the bottom when using panel mode with footer mode. I noticed in your screenshots from the other issue you posted on you were using a transparent header background, this will result in something like the screenshot below:

image

The grey portion is the iFrame and the header background is transparent, showing the views background behind it. This is by design to avoid overlap, but if you wanted to extend the iFrame completely behind the header you can use this advanced styling config:

panel_view_css: 'padding-bottom: 0px;'

I will close this issue when the next version is released, either today or tomorrow.

@blhoward2
Copy link
Author

blhoward2 commented Aug 29, 2020 via email

@maykar
Copy link
Owner

maykar commented Aug 30, 2020

Sorry, didn't make it into the most recent release. Will be in next one for sure, CH needed a quick fix for the next release of HA and I wanted to get it out there before people started upgrading HA.

@maykar
Copy link
Owner

maykar commented Sep 8, 2020

Apologize for the lateness, but this has been fixed in 1.7.7

@maykar maykar closed this as completed Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants