Merge pull request #170 from maykinmedia/feature/131-pyflake

Fixes #131 - Added flake8 to CI

.github/workflows/code_quality.yml

@@ -36,3 +36,17 @@ jobs:
         run: pip install -r requirements/dev.txt
       - name: Run black
         run: black --check --diff src
+
+  flake8:
+    name: Code style
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          python-version: '3.8'
+      - name: Install dependencies
+        run: pip install -r requirements/dev.txt
+      - name: Run flake8
+        run: flake8 src

setup.cfg

@@ -16,6 +16,13 @@ known_django=django
 known_first_party=archiefvernietigingscomponent
 sections=FUTURE,STDLIB,DJANGO,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
 
+; black compatible settings
+[flake8]
+; absolute maximum - more lenient than black's 88
+max-line-length = 119
+ignore = E121,E123,E126,E226,E24,E704,W503,W504,E231,F405,E203
+exclude = migrations,static,media
+
 [coverage:run]
 branch = True
 source = src

src/archiefvernietigingscomponent/accounts/management/commands/createinitialsuperuser.py

@@ -28,9 +28,7 @@ def handle(self, *args, **options):
             return
 
         password = User.objects.make_random_password(length=20)
-        user = User.objects.create_superuser(
-            username=username, email=email, password=password
-        )
+        User.objects.create_superuser(username=username, email=email, password=password)
 
         try:
             link = f'{settings.ALLOWED_HOSTS[0]}{reverse("admin:index")}'

src/archiefvernietigingscomponent/destruction/tests/test_landing_page.py

@@ -1,7 +1,6 @@
 """
 Test the various role landing pages.
 """
-from django.test import override_settings
 from django.urls import reverse, reverse_lazy
 
 from django_webtest import WebTest

src/archiefvernietigingscomponent/destruction/tests/test_review_create.py

@@ -112,7 +112,7 @@ def test_create_review_approve(self):
 
     def test_create_review_change(self):
         destruction_list = self._create_destruction_list()
-        next_assignee = DestructionListAssigneeFactory.create(
+        DestructionListAssigneeFactory.create(
             destruction_list=destruction_list, assignee__role=self.user.role
         )
         items = destruction_list.items.order_by("id").all()

src/archiefvernietigingscomponent/destruction/tests/test_tasks.py

@@ -2,7 +2,6 @@
 from unittest.mock import patch
 
 from django.conf import settings
-from django.contrib.sites.models import Site
 from django.core import mail
 from django.test import TestCase, override_settings
 from django.urls import reverse

src/archiefvernietigingscomponent/report/models.py

@@ -1,5 +1,3 @@
-import uuid as _uuid
-
 from django.core.exceptions import ValidationError
 from django.db import models
 from django.utils.translation import ugettext_lazy as _

src/archiefvernietigingscomponent/report/utils.py

@@ -1,4 +1,3 @@
-import uuid
 from datetime import date, datetime
 from typing import Optional
 
@@ -46,7 +45,7 @@ def get_looptijd(zaak: dict) -> int:
 def get_vernietigings_categorie_selectielijst(selectielijst_procestype: str) -> str:
     try:
         process_type = fetch_process_type(selectielijst_procestype)
-    except ClientError as exc:
+    except ClientError:
         # If the process type couldn't be retrieved, return an empty value
         return ""
 
@@ -73,7 +72,7 @@ def get_destruction_list_archivaris_comments(destruction_list: DestructionList)
 def get_zaaktype(zaaktype_url: str) -> dict:
     try:
         return fetch_zaaktype(zaaktype_url)
-    except ClientError as exc:
+    except ClientError:
         # If the zaaktype couldn't be retrieved, return an empty dictionary
         return {}
 

src/archiefvernietigingscomponent/theme/models.py

@@ -18,7 +18,8 @@ class ThemeConfig(SingletonModel):
     logo = models.FileField(
         upload_to="theme/",
         help_text=_(
-            "Image will be scaled down to a height of 100 pixels. Typically upload a picture with a height of 200 pixels."
+            "Image will be scaled down to a height of 100 pixels. "
+            "Typically upload a picture with a height of 200 pixels."
         ),
     )
 
@@ -68,7 +69,8 @@ class ThemeConfig(SingletonModel):
         default="017092",
         validators=[validate_color],
         help_text=_(
-            "Typically a darker shade or contrasting color of the primary color, used for button hover states, panel headers and outlines."
+            "Typically a darker shade or contrasting color of the primary color, used for button hover states, "
+            "panel headers and outlines."
         ),
     )
 

src/archiefvernietigingscomponent/wsgi.py

@@ -6,8 +6,6 @@
 For more information on this file, see
 https://docs.djangoproject.com/en/2.2/howto/deployment/wsgi/
 """
-import os
-
 from django.core.wsgi import get_wsgi_application
 
 from archiefvernietigingscomponent.setup import setup_env