This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Set up automatic patching/unpatching based on setting change #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two_factor/apps.py
Outdated
|
|
||
| @receiver(setting_changed, dispatch_uid="two_factor.handle_setting_changed") | ||
| def handle_setting_changed(sender, setting: str, value, **kwargs): | ||
| from .admin import patch_admin, unpatch_admin, __default_admin_site__ |
There was a problem hiding this comment.
why did you put the import here?
There was a problem hiding this comment.
Circular dependencies, apps.py is imported before everything else, and if that pulls in admin.py before django is ready, then everything collapses.
two_factor/apps.py
Outdated
| unpatch_admin() | ||
|
|
||
| elif setting == "TWO_FACTOR_FORCE_OTP_ADMIN": | ||
| if is_patched: |
There was a problem hiding this comment.
you can probably put this "if" in the "elif statement" in order to combine them no?
elif setting == "TWO_FACTOR_FORCE_OTP_ADMIN" and is_patched:
There was a problem hiding this comment.
I decided to go with readability & symmetry with the above if-statement to make it clear we're only looking at two settings.
annashamray
approved these changes
Aug 18, 2021
This makes it possible to use @override_settings in tests to control 2FA behaviour.
sergei-maertens
force-pushed
the
feature/patch-unpatch-on-settings-changed
branch
from
c11a4b7
to
4129802
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use @override_settings in tests to control 2FA behaviour.