Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sauce testing #6

Merged
merged 14 commits into from Jul 19, 2017
Merged

Sauce testing #6

merged 14 commits into from Jul 19, 2017

Conversation

JostCrow
Copy link
Collaborator

No description provided.

svenvandescheur
svenvandescheur requested changes Jul 13, 2017
View reviewed changes
Copy link
Collaborator

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

karma.conf.js Outdated
browserStack: {
username: '',
accessKey: ''
if (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to run saucelabs even on local? I'd suggest detecting process.env.CI i.c.w. a setting to check if we're on Travis (https://docs.travis-ci.com/user/environment-variables/#Convenience-Variables) or explicitly say we want to test against Sauce Labs.

package.json
@@ -33,6 +33,7 @@
"karma-jasmine": "^1.0.2",
"karma-jasmine-ajax": "^0.1.13",
"karma-jasmine-jquery": "^0.1.1",
"karma-sauce-launcher": "^1.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove karma-browserstack-launcher.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is removed!

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage remained the same at 91.803% when pulling 4ed913a on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage remained the same at 91.803% when pulling 4ed913a on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited

Coverage Status

Coverage remained the same at 91.803% when pulling 5a891b9 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.803% when pulling 9326749 on sauce-testing into dd8d78e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.803% when pulling 9326749 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 17, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling cc75026 on sauce-testing into dd8d78e on master.

@JostCrow JostCrow mentioned this pull request Jul 17, 2017
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 8880763 on sauce-testing into dd8d78e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 8880763 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 17, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling f97b922 on sauce-testing into dd8d78e on master.

@svenvandescheur
Copy link
Collaborator

LGTM, but why are the tests failing?

@JostCrow
Copy link
Collaborator Author

https://wiki.saucelabs.com/display/DOCS/Test+Configuration+Options#TestConfigurationOptions-BrowserName

@JostCrow JostCrow closed this Jul 17, 2017
@JostCrow JostCrow reopened this Jul 17, 2017
lintly-bot
lintly-bot reviewed Jul 17, 2017
View reviewed changes
Copy link

@lintly-bot lintly-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

karma.conf.js
browserStack: {
username: '',
accessKey: ''
if (process.env.CI && (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-undef: 'process' is not defined.

karma.conf.js
browserStack: {
username: '',
accessKey: ''
if (process.env.CI && (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-undef: 'process' is not defined.

karma.conf.js
browserStack: {
username: '',
accessKey: ''
if (process.env.CI && (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-undef: 'process' is not defined.

karma.conf.js Outdated
appiumVersion: "1.6.5",
deviceName: "Android Emulator",
deviceOrientation: "portrait",
browserName: "Chrome",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-dupe-keys: Duplicate key 'browserName'.

karma.conf.js
@@ -53,36 +128,17 @@ module.exports = function(config) {
webpackMiddleware: {
noInfo: true
},
colors: true,
recordScreenshots: false,
reporters: (process.env.TRAVIS) ? ['spec', 'coverage', 'coveralls', 'saucelabs'] : ['spec', 'coverage', 'saucelabs'],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-undef: 'process' is not defined.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 2375f25 on sauce-testing into dd8d78e on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 2375f25 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 2375f25 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 7a2554e on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling f2fc2c8 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 234a3ea on sauce-testing into dd8d78e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling 234a3ea on sauce-testing into dd8d78e on master.

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling a60cbe6 on sauce-testing into dd8d78e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling e0dda5a on sauce-testing into dd8d78e on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.935% when pulling e0dda5a on sauce-testing into dd8d78e on master.

@svenvandescheur svenvandescheur merged commit 1b4532c into master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lintly-bot lintly-bot lintly-bot left review comments

@svenvandescheur svenvandescheur svenvandescheur approved these changes

Assignees

@svenvandescheur svenvandescheur

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JostCrow @coveralls @svenvandescheur @lintly-bot