Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敡 [open-zaak/open-zaak#1629] Refactor settings module #190

Merged
merged 5 commits into from
Jul 2, 2024
Merged

馃敡 [open-zaak/open-zaak#1629] Refactor settings module #190

merged 5 commits into from
Jul 2, 2024

Conversation

stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented May 17, 2024 •
edited
Loading

partially fixes open-zaak/open-zaak#1629

Changes

  • Use base settings include from Open API Framework

@stevenbal stevenbal marked this pull request as draft May 17, 2024 15:03
@stevenbal stevenbal force-pushed the feature/refactor-settings branch 4 times, most recently from d72f4f6 to 94c5b2c Compare May 21, 2024 12:40
@stevenbal stevenbal changed the title Feature/refactor settings 馃敡 [open-zaak/open-zaak#1629] Refactor settings module May 21, 2024
@stevenbal stevenbal mentioned this pull request Jun 6, 2024
Merged
@stevenbal stevenbal marked this pull request as ready for review June 6, 2024 07:55
@stevenbal
馃敡 [open-zaak/open-zaak#1629] Refactor settings module
f7389d6 
use base settings from open-api-framework and modify production settings to support subpath
@stevenbal
馃敡 Enable mounting on subpath
c05f223
@stevenbal stevenbal mentioned this pull request Jun 6, 2024
Closed
9 tasks
@Coperh Coperh mentioned this pull request Jun 7, 2024
Merged
Coperh
Coperh reviewed Jun 7, 2024
View reviewed changes
src/openklant/conf/base.py Show resolved Hide resolved
src/openklant/conf/base.py Show resolved Hide resolved
src/openklant/conf/base.py Show resolved Hide resolved
@Coperh Coperh mentioned this pull request Jun 7, 2024
Merged
annashamray
annashamray approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll add also Bart as main Open Klant developer to double check

@stevenbal stevenbal marked this pull request as draft June 13, 2024 08:35
@stevenbal stevenbal marked this pull request as ready for review June 20, 2024 07:57
@stevenbal
Copy link
Collaborator Author

@bart-maykin could you do a double check so we can get this merged? :)

@joeribekker joeribekker merged commit 3d6b803 into master Jul 2, 2024
15 checks passed
@joeribekker joeribekker deleted the feature/refactor-settings branch July 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coperh Coperh Coperh left review comments

@annashamray annashamray annashamray approved these changes

@bart-maykin bart-maykin Awaiting requested review from bart-maykin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As PO I want to streamline all environment variables.
4 participants
@stevenbal @Coperh @annashamray @joeribekker