Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Service.oas_file field to save copy of OAS instead of fetching by URL #25

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Nov 18, 2021

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #25 (c468a33) into master (9b0759d) will increase coverage by 2.12%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   35.50%   37.62%   +2.12%     
==========================================
  Files          29       29              
  Lines        1090     1103      +13     
  Branches      154      156       +2     
==========================================
+ Hits          387      415      +28     
+ Misses        680      658      -22     
- Partials       23       30       +7     
Impacted Files Coverage Δ
zgw_consumers/client.py 71.79% <66.66%> (+13.73%) ⬆️
zgw_consumers/models.py 61.06% <100.00%> (+13.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0759d...c468a33. Read the comment docs.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review November 18, 2021 13:58
@Bartvaderkin
Copy link
Contributor Author

I thought about renaming the existing .oas URLField to .oas_url but decided against it for compatibility reasons.

@Bartvaderkin Bartvaderkin added the enhancement New feature or request label Nov 18, 2021
zgw_consumers/models.py Outdated Show resolved Hide resolved
@Bartvaderkin
Copy link
Contributor Author

I removed the unnecessary null attribute.

@sergei-maertens sergei-maertens merged commit 2d9b464 into master Nov 19, 2021
@sergei-maertens sergei-maertens deleted the feature/oas-file branch November 19, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants