Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/46 use django simple certmanager library #47

Merged

Conversation

Ewen-Lgy
Copy link

Fixes #46

Extracting the certficate manager to a standalone library

@Ewen-Lgy Ewen-Lgy linked an issue Aug 30, 2022 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #47 (f5ada3c) into main (6cd56ba) will decrease coverage by 5.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   51.71%   45.72%   -6.00%     
==========================================
  Files          40       37       -3     
  Lines        1512     1358     -154     
  Branches      249      223      -26     
==========================================
- Hits          782      621     -161     
- Misses        689      700      +11     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
zgw_consumers/admin.py 76.92% <ø> (-11.76%) ⬇️
zgw_consumers/constants.py 100.00% <ø> (ø)
zgw_consumers/utils.py 42.10% <ø> (-7.90%) ⬇️
zgw_consumers/models/certificates.py 100.00% <100.00%> (+1.75%) ⬆️
zgw_consumers/models/services.py 76.42% <100.00%> (-4.88%) ⬇️
zgw_consumers/client.py 64.70% <0.00%> (-15.69%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ewen-Lgy Ewen-Lgy force-pushed the feature/46-use-django-simple-certmanager-library branch from 27b59c5 to 1abf3b0 Compare August 30, 2022 09:40
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the translation files, there should be some that are gone now.

``django-admin makemessages -l nl`

CHANGELOG.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
zgw_consumers/migrations/0016_auto_20220818_1412.py Outdated Show resolved Hide resolved
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the forwards and reverse (data) migration on Open Forms project and it works as expected 👍

@sergei-maertens sergei-maertens merged commit 3fcc230 into main Aug 31, 2022
@sergei-maertens sergei-maertens deleted the feature/46-use-django-simple-certmanager-library branch August 31, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing internal cert-manager and use django-simple-certmanager library instead
2 participants