-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/46 use django simple certmanager library #47
Feature/46 use django simple certmanager library #47
Conversation
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 51.71% 45.72% -6.00%
==========================================
Files 40 37 -3
Lines 1512 1358 -154
Branches 249 223 -26
==========================================
- Hits 782 621 -161
- Misses 689 700 +11
+ Partials 41 37 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
27b59c5
to
1abf3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the translation files, there should be some that are gone now.
``django-admin makemessages -l nl`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the forwards and reverse (data) migration on Open Forms project and it works as expected 👍
Fixes #46
Extracting the certficate manager to a standalone library