Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/service url constraint #56

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

annashamray
Copy link
Contributor

Added check constrained for ServiceUrlField according to this comment: open-zaak/open-zaak#1242 (comment)

@annashamray annashamray mentioned this pull request Nov 15, 2022
16 tasks
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #56 (bdfa0e2) into main (95d0ad4) will increase coverage by 0.43%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   66.13%   66.56%   +0.43%     
==========================================
  Files          32       32              
  Lines        1317     1334      +17     
  Branches      185      188       +3     
==========================================
+ Hits          871      888      +17     
+ Misses        397      395       -2     
- Partials       49       51       +2     
Impacted Files Coverage Δ
zgw_consumers/models/fields.py 72.11% <83.33%> (+5.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joeribekker joeribekker requested review from joeribekker and removed request for joeribekker November 15, 2022 14:12
@sergei-maertens sergei-maertens merged commit fc9ddf1 into main Nov 15, 2022
@sergei-maertens sergei-maertens deleted the feature/service-url-constraint branch November 15, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants