Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Mac OS users to contribute without adding DS_store files. #1

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

HunterEl
Copy link
Contributor

GOAL:
Allow Mac OS users to contribute to this project without accidentally adding DS_store files.

CURRENT:
Currently, your .gitignore is very comprehensive, but I couldn't help but notice that it excluded some Mac OS specific files. Mac OS users are fairly large portion of the GH open-source community and it would be great if they could contribute without adding unnecessary files.

IMPACT:
This will allow for a smoother dev experience for theMac OS community.

@coveralls
Copy link

coveralls commented Jul 16, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling b828e39 on HunterEl:gitignore-addition-osx into 670e8ec on mayn:master.

@coveralls
Copy link

coveralls commented Jul 16, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling dd6f9f6 on HunterEl:gitignore-addition-osx into f11421e on mayn:master.

@mayn
Copy link
Owner

mayn commented Jul 16, 2017

@HunterEl thanks for your interest in packerlicious. It is through our community participation that we can make packerlicious great again.

But we can't do it without your help, please squash your commit. See our contribution guidelines

@HunterEl
Copy link
Contributor Author

@mayn thank you for adding a contributing file. I was curious if there was anything else extra you wanted me to do. I will squash the commits now. In the future, it might be worthwhile to set your Github repo settings to squash and merge.

@HunterEl
Copy link
Contributor Author

@mayn pull-request should be good for review. thanks!

@coveralls
Copy link

coveralls commented Jul 17, 2017

Coverage Status

Coverage remained the same at 0.0% when pulling 187864a on HunterEl:gitignore-addition-osx into 86f116d on mayn:master.

Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@mayn mayn merged commit 3197009 into mayn:master Jul 17, 2017
@dreamingbinary
Copy link

@mayn @HunterEl <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants