Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 127 setting source_ami_filter:owners to be required #142

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Fix for issue 127 setting source_ami_filter:owners to be required #142

merged 1 commit into from
Oct 18, 2018

Conversation

gnewson
Copy link
Contributor

@gnewson gnewson commented Oct 16, 2018

Issue

#127

List of Changes Proposed

Make source_ami_filter "owners" required

@gnewson
Copy link
Contributor Author

gnewson commented Oct 17, 2018

@mayn Any idea why the coverage checks haven't run on this?

@mayn
Copy link
Owner

mayn commented Oct 17, 2018

not sure. It has been happening on/off lately. Some issue on the coveralls/travis side.
I re-triggered the build, should clear it up.

@mayn mayn closed this Oct 17, 2018
@mayn mayn reopened this Oct 17, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9c41c30 on gnewson:127 into a48a61c on mayn:master.

@mayn
Copy link
Owner

mayn commented Oct 18, 2018

@gnewson , found the issue in travisci logs see #143

@mayn mayn merged commit 7c9b20e into mayn:master Oct 18, 2018
@mayn mayn added the builder label Oct 18, 2018
@mayn mayn added this to the 1.1.0 milestone Oct 18, 2018
@gnewson gnewson deleted the 127 branch October 22, 2018 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnewson @mayn @coveralls